I'm in Egypt as I write this. It was a long long time of planning, since before the government fell, and we decided not to change pour plans.
It IS worth it.
But a few things to consider.
The tourists are hear, but not in the numbers that they usually are. From talking to locals, tourism is about 10 - 30% of normal, which means you can actually DO things, and see things that you normally may get frustrated at. You can actually walk through the valley of the kings without pushing through crowds. Take pictures without hundreds of people in the way.
And the tourists are slowly returning. There are still protestors, but they are primarily only in Cairo. And the areas where the tourists go is 'safe' for a given definition of safe.
Vendors. With tourism down, that means that the economy is suffering. BADLY. The vendors will do ANYTHING if it means you will pay them. Be careful. But it also means you can get some nice deals on good quality souvenirs. If you are careful. The items you see the vendors hawking at various sops is generally cheap crap.
Take a Nile Cruise as part of your stay. We flew from Cairo to Aswan, and took a cruise from Aswan to Luxor. There are several stops. Many temples to visit, and we ended at the Valley of Kings. It is well, well worth it.
We will be hitting the museum tomorrow (Hopefully) and then spending a couple days in Sharm el Shiek to relax a bit.
Things to note:
Take a camera. With longs of battery power and spare memory cards. There are so many things to take pictures of.
Use a tour company. Not cheap, but worth it. They will pick you up from the airport, take you to your hotel, and make sure you have a good trip. Their reputation depends on it. They'll even ask if there is anything you want to do, and take you to reputable stores for those Egyptian goods.
Bring cash,. SMALL bills. If you aren't changing to Egyptian pounds, brings 1 dollar bills. You will need to tip your driver, your tour guides, etc etc. And a lot of things don't cost much, things tend to be cheap.
DP NOT RENT A CAR. Get a driver if you are not using a tour company. Drivers in Egypt are insane. Defensive driving does not exist. Don't even think about it. Imagine how you fell when someone cuts you off on the highway. Imagine EVERYONE is doing that to each other.
If you have more questions, I'll try to answer. I feel it is worth it to visit Egypt. I'm going to spend a total of two weeks here.. I could spend another two weeks, and still not see a fraction of everything there is here.